Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PaginateMode to the paginate api docs #1310

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add PaginateMode to the paginate api docs #1310

merged 1 commit into from
Jun 25, 2024

Conversation

SeppahBaws
Copy link
Collaborator

I noticed that the API docs didn't mention the @paginate directive's "mode" parameter at all, so I added a bit of documentation.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 13ef630

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited

✅ Deploy Preview for houdinigraphql ready!

Name Link
🔨 Latest commit 13ef630
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/667acc638f1966000838d491
😎 Deploy Preview https://deploy-preview-1310--houdinigraphql.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited

✅ Deploy Preview for houdini-docs-next ready!

Name Link
🔨 Latest commit 13ef630
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/667acc636cae2f00077b2d02
😎 Deploy Preview https://deploy-preview-1310--houdini-docs-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SeppahBaws SeppahBaws enabled auto-merge (squash) June 25, 2024 13:57
@SeppahBaws SeppahBaws merged commit cf2a102 into main Jun 25, 2024
14 checks passed
@SeppahBaws SeppahBaws deleted the docs/paginate-directive branch June 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlecAivazis AlecAivazis AlecAivazis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SeppahBaws @AlecAivazis